From 0ab2f179918d6d1c37c80f73cab25e9865a6e796 Mon Sep 17 00:00:00 2001
From: eugenijm <eugenijm@protonmail.com>
Date: Sat, 2 Feb 2019 17:04:07 +0300
Subject: [PATCH] Explicitly cast notification ids to integers when using them
for setting maxId
This fixes the bug where BE receives incorrect `since_id` when marking
notifications as read.
---
src/modules/statuses.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/modules/statuses.js b/src/modules/statuses.js
index 56619455..b58f8404 100644
--- a/src/modules/statuses.js
+++ b/src/modules/statuses.js
@@ -273,10 +273,11 @@ const addNewNotifications = (state, { dispatch, notifications, older, visibleNot
// Only add a new notification if we don't have one for the same action
if (!state.notifications.idStore.hasOwnProperty(notification.id)) {
- state.notifications.maxId = notification.id > state.notifications.maxId
+ const notificationId = parseInt(notification.id, 10)
+ state.notifications.maxId = notificationId > parseInt(state.notifications.maxId, 10)
? notification.id
: state.notifications.maxId
- state.notifications.minId = notification.id < state.notifications.minId
+ state.notifications.minId = notificationId < parseInt(state.notifications.minId, 10)
? notification.id
: state.notifications.minId