Merge pull request 'remove some jank in emoji reacts component' (#435) from Riedler/akkoma-fe:fix-reacts into develop

Reviewed-on: https://akkoma.dev/AkkomaGang/akkoma-fe/pulls/435

src/components/emoji_reactions/emoji_reactions.vue

@@ -11,7 +11,7 @@
         @click="emojiOnClick(reaction.name, $event)"
         @mouseenter="fetchEmojiReactionsByIfMissing()"
       >
-        <span
+        <template
           v-if="reaction.url !== null"
         >
           <StillImage
@@ -19,16 +19,15 @@
             :title="reaction.name"
             :alt="reaction.name"
             class="reaction-emoji"
-            height="2.55em"
           />
           {{ reaction.count }}
-        </span>
-        <span v-else>
+        </template>
+        <template v-else>
           <span class="reaction-emoji unicode-emoji">
             {{ reaction.name }}
           </span>
           <span>{{ reaction.count }}</span>
-        </span>
+        </template>
       </button>
     </UserListPopover>
     <a
@@ -53,23 +52,26 @@
   container-type: inline-size;
 }
 
-.unicode-emoji {
-  font-size: 210%;
-}
-
 .emoji-reaction {
-  padding: 0 0.5em;
+  padding: 2px 0.5em;
   margin-right: 0.5em;
   margin-top: 0.5em;
   display: flex;
-  align-items: center;
-  justify-content: center;
-  box-sizing: border-box;
+  align-items: end;
+
   .reaction-emoji {
     width: auto;
     max-width: 96cqw;
-    height: 2.55em !important;
     margin-right: 0.25em;
+
+    &.still-image {
+      height: 2.55em;
+    }
+    &.unicode-emoji {
+      display: inline-block;
+      font-size: 2.125em; // assuming default line height of 1.2rem and emojis that don't exceed line height
+      line-height: 2.55rem;
+    }
   }
   &:focus {
     outline: none;
@@ -97,9 +99,9 @@
 }
 
 .button-default.picked-reaction {
-  border: 1px solid var(--accent, $fallback--link);
-  margin-left: -1px; // offset the border, can't use inset shadows either
-  margin-right: calc(0.5em - 1px);
+  &, &:hover {
+    box-shadow: inset 0 0 0 1px var(--accent, $fallback--link);
+  }
 }
 
 </style>